Mark Wu has uploaded a new change for review.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Move option 'save_image_format' to qemu.conf
'save_image_format' is an option for qemu.conf, not libvirtd.conf, so move it to qemu.conf.
Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/vdsmd.init.in 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/5928/1 -- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 10: so move it to qemu.conf. Ouch. This is pretty painful. Thanks for fixing.
Could you check how this change would affect our users with images already-saved with gzip compression? Would libvirt be able to restore them? (if not, it makes a nice libvirt feature request).
.................................................... File vdsm/vdsmd.init.in Line 276: local by_vdsm_vers="4.9.7" I think 4.10 would be more informative
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 10: so move it to qemu.conf. This option is only used to create image, not used to read image. Libvirt adds a header to the image file, which contains a field of compress type. It can choose right program to decompress according the image header. So I think it's safe to change it. Thanks to libvirt already covering it. By the way, do we really want to use lzop? If yes, I think we need add a requires of it. Otherwise, it will fail to hibernate a vm on a host which doesn't have it installed. Because of the wrong location of the option, libvirt just use the default option 'raw' to save image. So no problem reported even without lzop.
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 1: (1 inline comment)
please update by_vdsm_vers, and I'll take your patch.
.................................................... Commit Message Line 10: so move it to qemu.conf. if there's no upgrade problem, cool.
lzop is already required by libvirt-daemon, so there is no problem in this regard.
and yes, we want to use lzop: it gives non-negligible compression of guest memory (which is quite empty quite often) without delaying hibernation very much (or so I was told).
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2:
Dan, Could you please review my v2 patch when you get time? Thanks!
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2: Looks good to me, approved
Sorry for the long delay. However, there are people other than me who could have reviewed this code too.
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2:
Jenkins failed in the test of ResourceManagerTests.testStressTest because it can't create a new thread due to the ulimit of process number. It's not related to this patch
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/201/
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/201/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move option 'save_image_format' to qemu.conf ......................................................................
Move option 'save_image_format' to qemu.conf
'save_image_format' is an option for qemu.conf, not libvirtd.conf, so move it to qemu.conf.
Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/vdsmd.init.in 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org