Roy Golan has uploaded a new change for review.
Change subject: fenceNode API is missing the options argument ......................................................................
fenceNode API is missing the options argument
Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Signed-off-by: Roy Golan rgolan@redhat.com --- M vdsm/BindingXMLRPC.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/7058/1 -- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/276/
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/276/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Eli Mesika has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 1: Looks good to me, approved
ouch, that's a nasty omision.
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Roy Golan has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/402/
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/402/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Omer Frenkel has posted comments on this change.
Change subject: fenceNode API is missing the options argument ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fenceNode API is missing the options argument ......................................................................
fenceNode API is missing the options argument
Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Signed-off-by: Roy Golan rgolan@redhat.com --- M vdsm/BindingXMLRPC.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Omer Frenkel: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgolan@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org