Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#785717 caps: cpuCores should report only physical cores ......................................................................
BZ#785717 caps: cpuCores should report only physical cores
CPU Hyper-Thread shows up as a processor in /proc/cpuinfo, but does not amount to a physical core.
Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528 --- M vdsm/caps.py 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/1737/1 -- To view, visit http://gerrit.ovirt.org/1737 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#785717 caps: cpuCores should report only physical cores ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
(1 inline comment)
code works, code snippet checked.
.................................................... File vdsm/caps.py Line 76: return len(set( (p['core id'], p['physical id']) for p should it return only *physical* cores number, not logical cores?
ok.
(btw, in bugzilla I've got «You are not authorized to access bug #785717»
-- To view, visit http://gerrit.ovirt.org/1737 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#785717 caps: cpuCores should report only physical cores ......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
.................................................... File vdsm/caps.py Line 76: return len(set( (p['core id'], p['physical id']) for p yeah, "cpuCores should report only physical cores". No idea why the bug is not public.
-- To view, visit http://gerrit.ovirt.org/1737 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#785717 caps: cpuCores should report only physical cores ......................................................................
BZ#785717 caps: cpuCores should report only physical cores
CPU Hyper-Thread shows up as a processor in /proc/cpuinfo, but does not amount to a physical core.
Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528 --- M vdsm/caps.py 1 file changed, 4 insertions(+), 3 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1737 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
vdsm-patches@lists.fedorahosted.org