From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move to lib/vdsm ......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/78070/3/lib/vdsm/storage/blockSD.py File lib/vdsm/storage/blockSD.py:
Line 61: Line 62: import vdsm.storage.blockVolume Line 63: import vdsm.storage.resourceFactories as resourceFactories Line 64: import vdsm.storage.sd as sd Line 65: import vdsm.storage.sdm as sdm
We should not have any circular dependencies. If we have such deps, we must
Nir, I think is too tough. For example, sdc imports blockSD which imports blockVolume which imports blockSD and sdc.
These circles exist in the storage code since ever; Piotr must not add any new one, but his patch is a positive step even without solving the existing problems.
In my opinion, it should be enough to explain why a simple
from . import sd
does not work. Line 66: Line 67: STORAGE_DOMAIN_TAG = "RHAT_storage_domain" Line 68: STORAGE_UNREADY_DOMAIN_TAG = STORAGE_DOMAIN_TAG + "_UNREADY" Line 69:
vdsm-patches@lists.fedorahosted.org