Nir Soffer has uploaded a new change for review.
Change subject: dockerfile: Install developer tools using pip ......................................................................
dockerfile: Install developer tools using pip
- Remove python-nose which is too old on CentOS, and install version 1.3.7 using pip - Install tox version 2.1.1 using pip. - Install mock, since python-mock is missing in CentOS. - Remove pyflakes and pep8 as they are installed using tox when running make check.
Change-Id: Ia4e10a727af5f75b6ede3cc271c2e32eac2fedd8 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M contrib/Dockerfile 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/65069/1
diff --git a/contrib/Dockerfile b/contrib/Dockerfile index 662881d..ff8affd 100644 --- a/contrib/Dockerfile +++ b/contrib/Dockerfile @@ -17,7 +17,6 @@ python-inotify \ python-ioprocess \ python-netaddr \ - python-nose \ python-pthreading \ python-setuptools \ python-six \ @@ -27,5 +26,4 @@ sanlock-python \ && \ easy_install pip && \ - easy_install pyflakes && \ - pip install pep8==1.5.6 + pip install nose==1.3.7 tox==2.1.1 mock
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install developer tools using pip ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Piotr Kliczewski has posted comments on this change.
Change subject: dockerfile: Install developer tools using pip ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65069/1/contrib/Dockerfile File contrib/Dockerfile:
PS1, Line 24: python34-nose what about this one?
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Install developer tools using pip ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65069/1/contrib/Dockerfile File contrib/Dockerfile:
Line 20: python-pthreading \ Line 21: python-setuptools \ Line 22: python-six \ Line 23: python34 \ Line 24: python34-nose \
what about this one?
This installs good version of nose, and when I tried, installing both python 2 and 3 stuff using pip does not work correctly, the last install overrides the previous install.
The only way that works is using tox, but we are far from a good tox based solution.
This patch fixes the current dockerfile so the test run on both python 2 and python 3.
For this we have to accept ugliness of installing python 2 packages using pip and python 3 packages using yum.
If you have a better solution please send a patch :-) Line 25: python34-six \ Line 26: sanlock-python \ Line 27: && \ Line 28: easy_install pip && \
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Install development tools using pip ......................................................................
Patch Set 4: Code-Review+2 Verified+1
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dockerfile: Install development tools using pip ......................................................................
dockerfile: Install development tools using pip
- Remove python-nose which is too old on CentOS, and install version 1.3.7 using pip - Install tox version 2.1.1 using pip. - Install mock, since python-mock is missing in CentOS. - Remove pyflakes and pep8 as they are installed using tox when running make check.
Note that for python 3, we install the ditribution packages. pip does not handle well intalling both python 2 and 3 packages. The long term solution is to install all the development tools using tox, each in its own isolated environment, but we are not there yet.
Change-Id: Ia4e10a727af5f75b6ede3cc271c2e32eac2fedd8 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65069 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com Tested-by: Dan Kenigsberg danken@redhat.com --- M contrib/Dockerfile 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org