Nir Soffer has uploaded a new change for review.
Change subject: travis: Switch to Fedora docker image ......................................................................
travis: Switch to Fedora docker image
The previous CentOS image cannot run the python 3 tests because some packages are missing; use Fedora image instead.
We should check later how to configure multiple builds with both CentOS and Fedora images.
Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M .travis.yml 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/65268/1
diff --git a/.travis.yml b/.travis.yml index 96dd9c3..666b020 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,7 +9,7 @@
before_install: - docker --version - - docker pull nirs/vdsm-centos + - docker pull nirs/vdsm-fedora
script: - - docker run --privileged --rm -it -v `pwd`:/vdsm:Z nirs/vdsm-centos bash -c "cd /vdsm && ./autogen.sh --system && make; make check" + - docker run --privileged --rm -it -v `pwd`:/vdsm:Z nirs/vdsm-fedora bash -c "cd /vdsm && ./autogen.sh --system && make && make check"
gerrit-hooks has posted comments on this change.
Change subject: travis: Switch to Fedora docker image ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: travis: Switch to Fedora docker image ......................................................................
Patch Set 1: Verified+1
Verified using travis.
- All python 2 tests pass - 795 python 3 tests pass - 2 python 3 tests error - I believe the tests are bad, running them on a container revel the issue
See https://travis-ci.org/nirs/vdsm/builds/166142758
Dan Kenigsberg has posted comments on this change.
Change subject: travis: Switch to Fedora docker image ......................................................................
Patch Set 1: Code-Review-1
I'd love to cover Python 3, it's an important future-facing effort. But keeping an eye open over CentOS is even more important. After all, some %90 of our install base use el7.
Can github be asked to run both?
Nir Soffer has posted comments on this change.
Change subject: travis: Switch to Fedora docker image ......................................................................
Patch Set 1:
Yes, we can run both in the same build, but since we run privileged docker and test changes in the kernel (e.g. adding and removing devices), the first docker run can effect the second run.
The best would be to create a matrix running 2 builds, one with the centos image, and one with the fedora image. I could not find how to configure this yet.
I'll add the fedora run after the centos run instead of replacing it.
gerrit-hooks has posted comments on this change.
Change subject: travis: Add Fedora docker run ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: travis: Add Fedora docker run ......................................................................
Patch Set 2: Verified+1
Both centos and fedora are running now: https://travis-ci.org/nirs/vdsm/builds/166247365
gerrit-hooks has posted comments on this change.
Change subject: travis: Add Fedora 24 build ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: travis: Add Fedora 24 build ......................................................................
Patch Set 3: Verified+1
See https://travis-ci.org/nirs/vdsm/builds/166263228
Dan Kenigsberg has posted comments on this change.
Change subject: travis: Add Fedora 24 build ......................................................................
Patch Set 3: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: travis: Add Fedora 24 build ......................................................................
travis: Add Fedora 24 build
The previous CentOS build cannot run the python 3 tests because some packages are missing; Add Fedora 24 build that can run all tests.
Using env matrix, two sub-builds are created for each build, each using a different docker image.
Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65268 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com --- M .travis.yml 1 file changed, 7 insertions(+), 2 deletions(-)
Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved
gerrit-hooks has posted comments on this change.
Change subject: travis: Add Fedora 24 build ......................................................................
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org