From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support ......................................................................
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/30/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py:
Line 272: protocols = [] Line 273: Line 274: for no_protocol in config.get('vars', 'ssl_protocol').split(','): Line 275: if no_protocol != '': Line 276: protocols.append(getattr(ssl, no_protocol.strip()))
PROTOCOL_TLS is not available on all platforms we use that is why we decide
PROTOCOL_TLS and PROTOCOL_SSLv23 are two differnt names for the same value (2). I believe that we don't want SSLContext with anything other that protocol=2. But maybe I'm missing something Line 277:
vdsm-patches@lists.fedorahosted.org