Yeela Kaplan has uploaded a new change for review.
Change subject: Add caps test ......................................................................
Add caps test
Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Signed-off-by: y kaplan ykaplan@redhat.com --- M tests/Makefile.am A tests/capsTests.py A tests/cpu_info.out 3 files changed, 659 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/3888/1 -- To view, visit http://gerrit.ovirt.org/3888 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add caps test ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
minor comments, thanks!
.................................................... File tests/capsTests.py Line 33: dir = os.path.split(testPath)[0] why use testrunner? __file__ is just as good, no?
btw, "dir" is a python builtin. it might be better to coose another name.
.................................................... File tests/Makefile.am Line 32: capsTests.py please keep sorted (hooksTest was out of order, too).
-- To view, visit http://gerrit.ovirt.org/3888 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add caps test ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3888 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add caps test ......................................................................
Patch Set 2: Verified
Thanks! keep this coming!
-- To view, visit http://gerrit.ovirt.org/3888 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add caps test ......................................................................
Add caps test
Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Signed-off-by: y kaplan ykaplan@redhat.com --- M tests/Makefile.am A tests/capsTests.py A tests/cpu_info.out 3 files changed, 659 insertions(+), 3 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3888 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I1ca8f98b5cf9d877cc30a9e4ed6f826f9b1be14c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com
vdsm-patches@lists.fedorahosted.org