From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has uploaded a new change for review.
Change subject: logutils: drop TracebackRepeatFilter ......................................................................
logutils: drop TracebackRepeatFilter
Since its introduction in prehitoric commit 6f8a7a7 due to rhbz#572050, logger.conf had a wrong reference to TracebackRepeatFilter. The class has never been used in production code, and it is time to retire it.
Change-Id: I599964083ea3827984da5a972dc2947ca8631740 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/logUtils.py M static/etc/vdsm/logger.conf.in M static/etc/vdsm/svdsm.logger.conf.in 3 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/77062/1
diff --git a/lib/vdsm/logUtils.py b/lib/vdsm/logUtils.py index 9b8e0c5..7a10976 100644 --- a/lib/vdsm/logUtils.py +++ b/lib/vdsm/logUtils.py @@ -97,26 +97,6 @@ return self.prefix + msg, kwargs
-class TracebackRepeatFilter(logging.Filter): - """ - Makes sure a traceback is logged only once for each exception. - """ - def filter(self, record): - if not record.exc_info: - return 1 - - info = sys.exc_info() - ex = info[1] - if ex is None: - return 1 - - if hasattr(ex, "_logged") and ex._logged: - record.exc_info = False - ex._logged = True - - return 1 - - class QueueHandler(logging.Handler): """ This handler sends events to a queue. Typically, it would be used together diff --git a/static/etc/vdsm/logger.conf.in b/static/etc/vdsm/logger.conf.in index 7be5f6b..d669a97 100644 --- a/static/etc/vdsm/logger.conf.in +++ b/static/etc/vdsm/logger.conf.in @@ -63,7 +63,6 @@ [handler_logfile] class=vdsm.logUtils.UserGroupEnforcingHandler args=('@VDSMUSER@', '@VDSMGROUP@', '@VDSMLOGDIR@/vdsm.log',) -filters=storage.misc.TracebackRepeatFilter level=DEBUG formatter=long
diff --git a/static/etc/vdsm/svdsm.logger.conf.in b/static/etc/vdsm/svdsm.logger.conf.in index 2b3e21e..c40624f 100644 --- a/static/etc/vdsm/svdsm.logger.conf.in +++ b/static/etc/vdsm/svdsm.logger.conf.in @@ -27,7 +27,6 @@ [handler_logfile] class=vdsm.logUtils.UserGroupEnforcingHandler args=('root', 'root', '@VDSMLOGDIR@/supervdsm.log',) -filters=storage.misc.TracebackRepeatFilter level=DEBUG formatter=long
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: logutils: drop TracebackRepeatFilter ......................................................................
Patch Set 2: Code-Review-1
ahhh bad rebase
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logutils: drop TracebackRepeatFilter ......................................................................
logutils: drop TracebackRepeatFilter
Since its introduction in prehitoric commit 6f8a7a7 due to rhbz#572050, logger.conf had a wrong reference to TracebackRepeatFilter. The class has never been used in production code, and it is time to retire it.
Change-Id: I599964083ea3827984da5a972dc2947ca8631740 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/common/logutils.py M static/etc/vdsm/logger.conf.in M static/etc/vdsm/svdsm.logger.conf.in 3 files changed, 0 insertions(+), 23 deletions(-)
Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Edward Haas: Verified; Looks good to me, but someone else must approve
vdsm-patches@lists.fedorahosted.org