Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm: fix make distcheck ......................................................................
vdsm: fix make distcheck
ERROR: files left in build directory after distclean: ./vdsm/constants.py ./vdsm/config.py ./vdsm/dumpStorageTable.py ./vdsm_cli/vdscli.py make[1]: *** [distcleancheck] Error 1
Change-Id: I972203f280ba883fb443c01df32be80380840eeb --- M vdsm/Makefile.am M vdsm_cli/Makefile.am 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/3199/1 -- To view, visit http://gerrit.ovirt.org/3199 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I972203f280ba883fb443c01df32be80380840eeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: fix make distcheck ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Ah great, thanks. Make sure it has no side effects.
-- To view, visit http://gerrit.ovirt.org/3199 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I972203f280ba883fb443c01df32be80380840eeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: fix make distcheck ......................................................................
Patch Set 1:
I have tested, no side effects.
-- To view, visit http://gerrit.ovirt.org/3199 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I972203f280ba883fb443c01df32be80380840eeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: fix make distcheck ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/3199 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I972203f280ba883fb443c01df32be80380840eeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: fix make distcheck ......................................................................
Patch Set 1: Looks good to me, approved
Thanks, we must automate this check in gerrit!
-- To view, visit http://gerrit.ovirt.org/3199 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I972203f280ba883fb443c01df32be80380840eeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: fix make distcheck ......................................................................
vdsm: fix make distcheck
ERROR: files left in build directory after distclean: ./vdsm/constants.py ./vdsm/config.py ./vdsm/dumpStorageTable.py ./vdsm_cli/vdscli.py make[1]: *** [distcleancheck] Error 1
Change-Id: I972203f280ba883fb443c01df32be80380840eeb --- M vdsm/Makefile.am M vdsm_cli/Makefile.am 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: Douglas Schilling Landgraf: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3199 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I972203f280ba883fb443c01df32be80380840eeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org