Nir Soffer has uploaded a new change for review.
Change subject: dockerfile: Add missing packages ......................................................................
dockerfile: Add missing packages
Add packages added recently as build requirement on master (python-decorator, PyYaml, sanlock-python) and packages that were missing in the original file (python-setuptools).
Change-Id: I204be6a9b83af9d2b12abc8267d2d1ccd4fd746d Signed-off-by: Nir Soffer nsoffer@redhat.com --- M contrib/Dockerfile 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/65067/1
diff --git a/contrib/Dockerfile b/contrib/Dockerfile index 6e9ff5b..c0a38cb 100644 --- a/contrib/Dockerfile +++ b/contrib/Dockerfile @@ -2,6 +2,7 @@ RUN yum install -y http://resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm && \ yum update -y && \ yum install -y \ + PyYAML \ autoconf \ automake git \ libselinux-python \ @@ -9,16 +10,19 @@ make \ psmisc \ python-cpopen mom \ + python-decorator \ python-devel \ python-inotify \ python-ioprocess \ python-netaddr \ python-nose \ python-pthreading \ + python-setuptools \ python-six \ python34 \ python34-nose \ python34-six \ + sanlock-python \ && \ easy_install pip && \ easy_install pyflakes && \
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Piotr Kliczewski has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/65067/1/contrib/Dockerfile File contrib/Dockerfile:
Line 1: FROM centos:7 I checked check-patch.packages.el7 and I can see packages like python-mock there. Line 2: RUN yum install -y http://resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm && \ Line 3: yum update -y && \ Line 4: yum install -y \ Line 5: PyYAML \
PS1, Line 7: git should be in separate line
PS1, Line 12: mom separate line
Piotr Kliczewski has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 1:
(2 comments)
Please make sure that we use the same set of depts in check-patch.packages.el7 and here. Not sure whether we should update one or the other.
https://gerrit.ovirt.org/#/c/65067/1/contrib/Dockerfile File contrib/Dockerfile:
PS1, Line 7: git
should be in separate line
I saw it in another patch
PS1, Line 12: mom
separate line
I saw it in another patch
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65067/1/contrib/Dockerfile File contrib/Dockerfile:
Line 1: FROM centos:7
I checked check-patch.packages.el7 and I can see packages like python-mock
I think it is available in some secret repo Sandro added. I prefer to get the package from pip. Line 2: RUN yum install -y http://resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm && \ Line 3: yum update -y && \ Line 4: yum install -y \ Line 5: PyYAML \
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 3: Code-Review+2 Verified+1
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dockerfile: Add missing packages ......................................................................
dockerfile: Add missing packages
Add missing packages: - PyYaml - dosfstools (for mkfs.msdos) - e2fsprogs (for mkfs.ext2) - genisoimage (for mkisofs) - python-decorator - python-setuptools (for easy_install) - sanlock-python - which (for which)
Change-Id: I204be6a9b83af9d2b12abc8267d2d1ccd4fd746d Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65067 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com Tested-by: Dan Kenigsberg danken@redhat.com --- M contrib/Dockerfile 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org