Federico Simoncelli has uploaded a new change for review.
Change subject: Add missing log object to CrabRPCServer ......................................................................
Add missing log object to CrabRPCServer
In this patch: * add missing log object to CrabRPCServer * rename _log to log for consistency with CrabRPCProxy and with the majority of the VDSM classes
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f --- M vdsm/storage/remoteFileHandler.py 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/7084/1 -- To view, visit http://gerrit.ovirt.org/7084 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Add missing log object to CrabRPCServer ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7084 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add missing log object to CrabRPCServer ......................................................................
Patch Set 1: Looks good to me, approved
doh, I should have noticed this "little" fact when reviewing http://gerrit.ovirt.org/6869
-- To view, visit http://gerrit.ovirt.org/7084 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Add missing log object to CrabRPCServer ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7084 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add missing log object to CrabRPCServer ......................................................................
Add missing log object to CrabRPCServer
In this patch: * add missing log object to CrabRPCServer * rename _log to log for consistency with CrabRPCProxy and with the majority of the VDSM classes
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f --- M vdsm/storage/remoteFileHandler.py 1 file changed, 5 insertions(+), 3 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7084 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I711d0d4f627a1f42886a65305f93bcd97deccd3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org