Shahar Havivi has uploaded a new change for review.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Clean libvirt networks if bridge not exists
Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 --- M vdsm/clientIF.py M vdsm/configNetwork.py M vdsm/netinfo.py 3 files changed, 55 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/1990/1 -- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
.................................................... File vdsm/clientIF.py Line 114: lvNetworks = self._libvirt.listNetworks() 1st call to listNetworks
Line 123: if netinfo.getnetworks()[network]['bridged'] and network not in netinfo.bridges(): n + 1 more calls to listNetwork.
wouldn't it be better to cache this? netinfo.get() is intended to get such a cache.
.................................................... File vdsm/configNetwork.py Line 650: logging.debug('failed to remove libvirt network %s' % netName) I find exc_info=True very helpful
.................................................... File vdsm/netinfo.py Line 58: def getnetworks(): Why not call this simply "networks" just the rest of the functions here?
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Patch Set 1: (4 inline comments)
.................................................... File vdsm/clientIF.py Line 114: lvNetworks = self._libvirt.listNetworks() Done
Line 123: if netinfo.getnetworks()[network]['bridged'] and network not in netinfo.bridges(): I would cache it locally because it is dynamic after all...
.................................................... File vdsm/configNetwork.py Line 650: logging.debug('failed to remove libvirt network %s' % netName) Done
.................................................... File vdsm/netinfo.py Line 58: def getnetworks(): Done
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Clean libvirt networks if bridge not exists ......................................................................
Clean libvirt networks if bridge not exists
Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 --- M vdsm/clientIF.py M vdsm/configNetwork.py M vdsm/netinfo.py 3 files changed, 58 insertions(+), 18 deletions(-)
Approvals: Shahar Havivi: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1990 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
vdsm-patches@lists.fedorahosted.org