Nir Soffer has uploaded a new change for review.
Change subject: virt: Improve spacing ......................................................................
virt: Improve spacing
Separting logic blocks make it easier to to understand the flow.
Change-Id: I94b751112db67398891820035a9ec06abed59c3b Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/40067/1
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py index 799f66c..af1ddd2 100644 --- a/vdsm/virt/vmdevices/storage.py +++ b/vdsm/virt/vmdevices/storage.py @@ -333,14 +333,17 @@
if self.extSharedState == DRIVE_SHARED_TYPE.SHARED: diskelem.appendChildWithArgs('shareable') + if hasattr(self, 'readonly') and utils.tobool(self.readonly): diskelem.appendChildWithArgs('readonly') elif self.device == 'floppy' and not hasattr(self, 'readonly'): # floppies are used only internally for sysprep, so # they are readonly unless explicitely stated otherwise diskelem.appendChildWithArgs('readonly') + if hasattr(self, 'serial'): diskelem.appendChildWithArgs('serial', text=self.serial) + if hasattr(self, 'bootOrder'): diskelem.appendChildWithArgs('boot', order=self.bootOrder)
@@ -380,10 +383,12 @@ def _getDriverXML(self): driver = vmxml.Element('driver') driverAttrs = {'name': 'qemu'} + if self.blockDev: driverAttrs['io'] = 'native' else: driverAttrs['io'] = 'threads' + if self.format == 'cow': driverAttrs['type'] = 'qcow2' elif self.format: @@ -396,6 +401,7 @@ driverAttrs['error_policy'] = 'enospace' else: driverAttrs['error_policy'] = 'stop' + driver.setAttrs(**driverAttrs) return driver
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 1:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17892/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 1:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18063/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18063/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17892/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 1: Verified+1
Francesco Romani has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 1: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 2:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17921/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 2:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18093/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18093/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17921/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 3:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18029/
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 3:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1258/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18029/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1258/ : 0
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 4:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18136/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 4:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1366/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18136/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1366/ : 0
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 5:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18182/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 5:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1412/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18182/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1412/ : 0
Adam Litke has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 5:
(1 comment)
Thanks! I was going to comment on this in the previous patch.
https://gerrit.ovirt.org/#/c/40067/5//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2015-04-25 15:22:00 +0300 Line 6: Line 7: virt: Improve spacing Line 8: Line 9: Separting logic blocks make it easier to to understand the flow. Separating Line 10: Line 11: Change-Id: I94b751112db67398891820035a9ec06abed59c3b
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 6: Verified+1
This version fixes typos in the commit message.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 6:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18383/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 6:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1613/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18383/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1613/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 6: Code-Review+2
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Improve spacing ......................................................................
virt: Improve spacing
Separating logical blocks make it easier to to understand the flow.
Change-Id: I94b751112db67398891820035a9ec06abed59c3b Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/40067 Reviewed-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved
automation@ovirt.org has posted comments on this change.
Change subject: virt: Improve spacing ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org