Adam Litke has uploaded a new change for review.
Change subject: schema: Remove invalid names ......................................................................
schema: Remove invalid names
The identifier "type" causes conflicts with the GObject type system. Type is not a great name anyway so choose better names where it occurs.
The name "StorageDomainClass" conflicts with the GObject class structure for the StorageDomain class. Rename it to StorageDomainImageClass since it identifies the class of images stored on the storage domain.
Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 79 insertions(+), 77 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/7013/1 -- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/10/
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/10/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/287/
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/287/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/299/
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/299/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Adam Litke has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/327/
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/327/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 4: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Adam Litke has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/440/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Remove invalid names ......................................................................
Patch Set 6: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has submitted this change and it was merged.
Change subject: schema: Remove invalid names ......................................................................
schema: Remove invalid names
The identifier "type" causes conflicts with the GObject type system. Type is not a great name anyway so choose better names where it occurs.
The name "StorageDomainClass" conflicts with the GObject class structure for the StorageDomain class. Rename it to StorageDomainImageClass since it identifies the class of images stored on the storage domain.
Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 79 insertions(+), 77 deletions(-)
Approvals: Adam Litke: Verified Saggi Mizrahi: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7013 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Idb43f5960f60a2064a5a41eeafcb7a7ef1899c77 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org