Mark Wu has uploaded a new change for review.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Add a VDSM verb to change MOM policy
Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/vdsmMOM.py M vdsm_cli/vdsClient.py 4 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/5069/1 -- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsmMOM.py Line 53: # Now MOM expects policy content not filename as input parameter I was not a huge fan of this new vdsm verb, but it would be much more useful if vdsm, just like MOM, accepts a string policy instead of a local filename.
There are many systems where it would be pretty difficult to log in a place this file; it would be much easier to maintain if Engine (or whomever controls multiple vdsms) can set the policy on all of its servers.
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Mark Wu has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/vdsmMOM.py Line 53: # Now MOM expects policy content not filename as input parameter Make sense! I will change it in next version
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
just a little question
.................................................... File vdsm/MOM.py Line 51: ret = self._mom.setPolicy(policyStr) wouldn't it be prettier and more pythonic if MOM.setPolicy has been raising an exception on error?
Also note that such an exception would be translated to an "Unexpected exception" error code 16, which I am not sure is what you want (I really do not know).
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
Unless the given policy is escaped, this may cause trouble in the future. Still, since I'd like to increase the resolution in the future for specific policy elements, I think we can start with this patch and improve.
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6:
Mark, no need to escape the policy string?
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6:
Doron, Sorry, I didn't understand what you're talking about. Any characters required to escape in XMLRPC? Could you please explain it or give me a pointer? Thanks!
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6:
I'm referring to setMOMPolicy(self, policy)
Is this an escaped xml struct?
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
Doron, I do not understand your issue, too. xmlrpclib does all the required escaping of the content for us. In Vdsm's perspective, it can be rather anything, passed as-is to mom.
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
I was trying to understand if the policy argument is an escaped string, which is the case for xml-rpc. So I'm fine.
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Add a VDSM verb to change MOM policy
Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/define.py M vdsm/momIF.py M vdsm_cli/vdsClient.py 5 files changed, 27 insertions(+), 0 deletions(-)
Approvals: Mark Wu: Verified Doron Fediuck: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org