Pradipta Banerjee has uploaded a new change for review.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
vdsm spec file changes for building on ppc64 architecture
Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Signed-off-by: Pradipta Kr. Banerjee bpradip@in.ibm.com --- M vdsm.spec.in 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/6871/1 -- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
Patch Set 1: Verified
Verified on F17 (ppc64 and x86_64)
-- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: Pradipta Banerjee bpradip@in.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
Patch Set 1: I would prefer that you didn't submit this
could you explain why would you want vdsm on ppc? do you even have qemu-kvm there? Is this the only change required?
I do not see any benefit in having a i686 build, either.
-- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpradip@in.ibm.com
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
Patch Set 1:
We need vdsm on ppc to manage KVM on POWER arch(ppc64) via ovirt-engine. qemu-kvm for ppc is there
This is not the only change. I plan to submit few more changes allow ppc64 support.
Do you want me to submit all the changes together ?
-- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpradip@in.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
Patch Set 1:
Yes, I prefer to have a context, given by a stack of patches on a single branch.
-- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpradip@in.ibm.com
Itamar Heim has posted comments on this change.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
Patch Set 1:
actually before patches - how about a feature page explaining how this is supposed to look like overall?
-- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpradip@in.ibm.com
Pradipta Banerjee has abandoned this change.
Change subject: vdsm spec file changes for building on ppc64 architecture ......................................................................
Patch Set 1: Abandoned
Resubmitted a combined patchset - http://gerrit.ovirt.org/7072
-- To view, visit http://gerrit.ovirt.org/6871 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ia2661eb8cc21ae77fa42e651604888d0b90809f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpradip@in.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org