Wenyi Gao has uploaded a new change for review.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Make safer to get vdsm section version in configuration files
For "configure_libvirt" function in vdsmd.init file, it only search the version number(currently it is "4.9.6") to make sure if vdsm section version is in configuration files. That is not enough safe if the same number but not vdsm section version maybe be in a configuration file.
So this patch serach vdsm specific version number in order to be safer.
Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Signed-off-by: Wenyi Gao wenyi@linux.vnet.ibm.com --- M vdsm/vdsmd.init.in 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/5051/1 -- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com
Wenyi Gao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Hi Wenyi, thanks for your patch. However, I don't think it's required. We have split the version purposely. Please let me know if I missed something.
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
Wenyi Gao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: No score
Hi Douglas, thanks for your comments. Currently, the version number is 4.9.6. We only search the number "4.9.6" to decide if the vdsm section is in configuration files. If configuration files happen to have the same number, we will get something wrong. In the feature, the version number may be 6.0 or something else that is a simple number. I think it is always a potential problem.
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I think whether reconfigure or not just judged by whether the version number has changes before. And your worry is unnecessary. Maybe I missed something.:)
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/108/
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/108/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Wenyi Gao has abandoned this change.
Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: Abandoned
Invalid
-- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org