Adam Litke has uploaded a new change for review.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Remove orphaned API: getStorageConnections
Commit a1cdccdff54af7aea8de49c06d8535079cd78bff which introduced the Storage Connections Management API removed an unimplemented API from the HSM but did not remove references to that API from API.py and BindingXMLRPC.py. Finish cleaning it up.
Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/API.py M vdsm/BindingXMLRPC.py 2 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/6107/1 -- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Adam, everybody: when you fix someone's patch, it's best to ask him to review the fix.
-- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Shu Ming has posted comments on this change.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Patch Set 1: Looks good to me, approved
If it's unused and acked by Saggi, I'm happy with killing it.
-- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove orphaned API: getStorageConnections ......................................................................
Remove orphaned API: getStorageConnections
Commit a1cdccdff54af7aea8de49c06d8535079cd78bff which introduced the Storage Connections Management API removed an unimplemented API from the HSM but did not remove references to that API from API.py and BindingXMLRPC.py. Finish cleaning it up.
Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/API.py M vdsm/BindingXMLRPC.py 2 files changed, 0 insertions(+), 8 deletions(-)
Approvals: Adam Litke: Verified Shu Ming: Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6107 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If48da46ba371171a575281a7578cdd006f4e33ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org