Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#832765 - Load backups from from backup files to memory ......................................................................
BZ#832765 - Load backups from from backup files to memory
Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/6967/1 -- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
minor comments
.................................................... File vdsm/configNetwork.py Line 318: if os.path.exists(loadDir): it would be shorter to have
for fpath in glob.iglob(loadDir + '/*'):
Line 323: content = open(fpath).read() I'd write
if content.startswith(self.DELETED_HEADER): content = None
here, and only once.
Line 332: logging.info('Loading %s', fpath) loading -> loaded
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 6: (2 inline comments)
.................................................... File vdsm/configNetwork.py Line 320: if os.path.isfile(fpath): how about saving us an annoying level of indentation with
if not os.path.isfile(fpath): continue
?
Line 328: os.path.basename(fpath))] = content ah, sorry... I did not notice that "f" was used here... If I did, I would not have suggested the recent change.
how about setting
basename = os.path.basename(fpath)
once?
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 7:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests/946/
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests/946/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 7: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 8:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/280/
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/280/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
Patch Set 8: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#832765 - Load backups from backup files to memory ......................................................................
BZ#832765 - Load backups from backup files to memory
Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 25 insertions(+), 0 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org