Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove HexStr alias ......................................................................
(Schema) Remove HexStr alias
Most languages have their own way of representing hexadecimal literals. This will make sure we don't have to define how we parse hex values and making users implement formatters.
Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 2 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/6840/1 -- To view, visit http://gerrit.ovirt.org/6840 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Adam Litke has posted comments on this change.
Change subject: (Schema) Remove HexStr alias ......................................................................
Patch Set 1:
Agree in principle but not +1 'ing due to discussion around integer sizes.
-- To view, visit http://gerrit.ovirt.org/6840 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Adam Litke has posted comments on this change.
Change subject: (Schema) Remove HexStr alias ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
uint16 -> uint
.................................................... File vdsm_api/vdsmapi-schema.json Line 1596: 'domain': 'uint16', 'function': 'uint16'}} oops. These need to be 'uint'
-- To view, visit http://gerrit.ovirt.org/6840 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has submitted this change and it was merged.
Change subject: (Schema) Remove HexStr alias ......................................................................
(Schema) Remove HexStr alias
Most languages have their own way of representing hexadecimal literals. This will make sure we don't have to define how we parse hex values and making users implement formatters.
Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 2 insertions(+), 11 deletions(-)
Approvals: Saggi Mizrahi: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6840 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: (Schema) Remove HexStr alias ......................................................................
Patch Set 4: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6840 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org