Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
seboolsetup: fenced_can_network_connect/can_ssh
fenced_can_ssh - Allow fenced domain to execute ssh. fenced_can_network_connect - Allow fenced domain to connect to the network using TCP.
Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b BugUrl: https://bugzilla.redhat.com/show_bug.cgi?id=902140 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm-tool/seboolsetup.py 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/11764/1
diff --git a/vdsm-tool/seboolsetup.py b/vdsm-tool/seboolsetup.py index 437da68..d0f2b35 100644 --- a/vdsm-tool/seboolsetup.py +++ b/vdsm-tool/seboolsetup.py @@ -25,13 +25,15 @@ SEBOOL_DISABLED = "off"
VDSM_SEBOOL_LIST = [ + "fenced_can_network_connect", + "fenced_can_ssh", + "sanlock_use_fusefs", + "sanlock_use_nfs", + "sanlock_use_samba", "virt_use_fusefs", "virt_use_nfs", "virt_use_samba", "virt_use_sanlock", - "sanlock_use_fusefs", - "sanlock_use_nfs", - "sanlock_use_samba", ]
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1146/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1181/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/292/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1146/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1181/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/292/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 10: fenced_can_network_connect - Allow fenced domain to Line 11: connect to the network using TCP. Line 12: Line 13: Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Line 14: BugUrl: https://bugzilla.redhat.com/show_bug.cgi?id=902140 Bug-Url is not spelled properly, and the bug itself is not accessible.
Please do not refer to such bugs, or open them up.
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1183/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/294/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1148/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1148/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1183/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/294/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2: I would prefer that you didn't submit this
I have to retract my +2, as I heard rumors that we do not really understand what fenced_can_ssh is for. I'd rather understand that before setting it to "on".
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has abandoned this change.
Change subject: seboolsetup: fenced_can_network_connect/can_ssh ......................................................................
Patch Set 2: Abandoned
-- To view, visit http://gerrit.ovirt.org/11764 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I7317c8da1f99c354eb4f56a857848adb182b281b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org