Federico Simoncelli has uploaded a new change for review.
Change subject: Initialize the pthread RLock attribute ......................................................................
Initialize the pthread RLock attribute
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a --- M vdsm/pthread.py 1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/6988/1 -- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/pthread.py Line 74: _libpthread.pthread_mutexattr_init(C.byref(self._attr)) I understand why it is sane to initialize attr to a non-random value.
but why do we need to keep _attr as a data member? and if so, shouldn't it be added to __slots__?
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/pthread.py Line 74 I still do not understand why you've made all these changes...
why adding
_libpthread.pthread_mutexattr_init(attr)
to the old code would not have been enough.
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Omri Hochman has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 3: I would prefer that you didn't submit this
for visibility
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 3: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/48/
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/48/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
.................................................... File vdsm/pthread.py Line 136: C.pointer(abstime)) didn't you want to get rid of this en route?
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Initialize the pthread RLock attribute ......................................................................
Initialize the pthread RLock attribute
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a --- M vdsm/pthread.py 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org