Alon Bar-Lev has uploaded a new change for review.
Change subject: configNetworkTests: handle modinfo correctly ......................................................................
configNetworkTests: handle modinfo correctly
1. Use /sbin/modinfo as /sbin is absent from non root users.
2. If bonding module was not found, skip test.
Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M tests/configNetworkTests.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/6930/1 -- To view, visit http://gerrit.ovirt.org/6930 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: configNetworkTests: handle modinfo correctly ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/configNetworkTests.py Line 143: p = subprocess.Popen(['/sbin/modinfo', 'bonding'], would this fly in F17 with its beloved /sbin mess?
-- To view, visit http://gerrit.ovirt.org/6930 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: configNetworkTests: handle modinfo correctly ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/configNetworkTests.py Line 143: p = subprocess.Popen(['/sbin/modinfo', 'bonding'], yes.
/sbin->/usr/sbin
-- To view, visit http://gerrit.ovirt.org/6930 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: configNetworkTests: handle modinfo correctly ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6930 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configNetworkTests: handle modinfo correctly ......................................................................
configNetworkTests: handle modinfo correctly
1. Use /sbin/modinfo as /sbin is absent from non root users.
2. If bonding module was not found, skip test.
Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M tests/configNetworkTests.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: oVirt Jenkins CI Server: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6930 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia71ee7b16e645da8cbedf43d8f9138c5a40e2021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org