Alon Bar-Lev has uploaded a new change for review.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
cleanup: use iproute instead of vconfig for vlan management
**EXPERIMENTAL**
iproute utility is much better maintained and supported, it supersedes the vconfig in most setups.
As VDSM uses vconfig only to delete vlans, it even simpler to replace it with iproute at this point.
Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M configure.ac M vdsm.spec.in M vdsm/configNetwork.py M vdsm/constants.py.in 4 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/6139/1 -- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... Commit Message Line 9: **EXPERIMENTAL** I suppose you are right, and annihilation of ifconfig should follow suit.
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 2:
Rebased.
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 2: I would prefer that you didn't submit this
repeating my request to drop the "EXPERIMENTAL" thingy from commit message.
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 3:
repeating my request to drop the "EXPERIMENTAL" thingy from commit message.
I am sorry, I missed that.
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 3:
repeating my request to drop the "EXPERIMENTAL" thingy from commit message.
I am sorry, I missed that.
Hmmm... it is not documented :)
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
Patch Set 3: Looks good to me, approved
let's trust the robot.
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cleanup: use iproute instead of vconfig for vlan management ......................................................................
cleanup: use iproute instead of vconfig for vlan management
iproute utility is much better maintained and supported, it supersedes the vconfig in most setups.
As VDSM uses vconfig only to delete vlans, it even simpler to replace it with iproute at this point.
Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M configure.ac M vdsm.spec.in M vdsm/configNetwork.py M vdsm/constants.py.in 4 files changed, 4 insertions(+), 3 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Verified Dan Kenigsberg: Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6139 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Iae9acdd92f1775d70ced96a04047d40abfec2548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org