Wenyi Gao has uploaded a new change for review.
Change subject: make pep8 clean for scratchpad/after_vm_destropy.py ......................................................................
make pep8 clean for scratchpad/after_vm_destropy.py
Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a Signed-off-by: Wenyi Gao wenyi@linux.vnet.ibm.com --- M Makefile.am M vdsm_hooks/scratchpad/after_vm_destroy.py 2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/6532/1 -- To view, visit http://gerrit.ovirt.org/6532 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm_hooks/scratchpad/after_vm_destroy.py PEP 8 clean ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
Passes autobuild.sh. pydiff reports one change. It's changing "os.environ.has_key('scratchpad')" to "'scratchpad' in os.environ", acceptable.
-- To view, visit http://gerrit.ovirt.org/6532 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: make vdsm_hooks/scratchpad/after_vm_destroy.py PEP 8 clean ......................................................................
make vdsm_hooks/scratchpad/after_vm_destroy.py PEP 8 clean
Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a Signed-off-by: Wenyi Gao wenyi@linux.vnet.ibm.com --- M Makefile.am M vdsm_hooks/scratchpad/after_vm_destroy.py 2 files changed, 6 insertions(+), 4 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6532 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: make vdsm_hooks/scratchpad/after_vm_destroy.py PEP 8 clean ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6532 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org