Mark Wu has uploaded a new change for review.
Change subject: Add a MOM functional test case for KSM ......................................................................
Add a MOM functional test case for KSM
Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- A tests/functional/momTests.py 1 file changed, 54 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/5070/1 -- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
ShaoHe Feng has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/functional/momTests.py Line 36: whitespace, should set git to check whitespace?
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File tests/functional/momTests.py Line 44: with open(path, 'w') as f: you can use tempfile.NamedTemporaryFile directly. it needn't open file twice
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
ShaoHe Feng has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Thanks for the first xmlrpc-based functional test! we have to have more of those!
.................................................... File tests/functional/momTests.py Line 43: fd, path = mkstemp() heh, even the test is simplified if vdsm.setMOMPolicy accepts a string instead of a filename.
Line 52: for k in constants.KSM_PARAMS: I think it would be cooler to check the effect on getVdsStats.ksmPages etc.
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File tests/functional/momTests.py Line 46: self.assertEqual(run, hostStats['ksmState']) hmm, I'm pretty sure that hostStats['ksmState'] used to be True/False. Please check this.
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 7: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 7: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 8: Verified
Fix an import issue of vdscli. Probably it's caused by the hackVdsmModule is only called for local test now.
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Doron Fediuck has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 8: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 8: (1 inline comment)
.................................................... File tests/functional/momTests.py Line 24: import vdsm.vdscli as vdscli I prefer
from vdsm import vdscli
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 9: Verified
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Add a MOM functional test case for KSM ......................................................................
Patch Set 9: Looks good to me, approved
Thanks, Mark!
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add a MOM functional test case for KSM ......................................................................
Add a MOM functional test case for KSM
Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M tests/functional/Makefile.am A tests/functional/momTests.py 2 files changed, 48 insertions(+), 0 deletions(-)
Approvals: Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org