Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
tool: Fix help message when is-configured fails
When is-configured fails for some modules, the help message suggested an incorrect invocation:
vdsm-tool configure module-name
Instead of the correct:
vdsm-tool configure --module module-name
Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/31783 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/32059/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 12cc0af..b799fde 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -111,7 +111,7 @@
One of the modules is not configured to work with VDSM. To configure the module use the following: -'vdsm-tool configure [module_name]'. +'vdsm-tool configure [--module module-name]'.
If all modules are not configured try to use: 'vdsm-tool configure --force'
mooli tayer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
Patch Set 2:
Bug-url -> Bug-Url
Nir Soffer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
Patch Set 3: Code-Review+1
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
Patch Set 3: Code-Review+2
mooli tayer has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
Patch Set 3: Verified+1
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: Fix help message when is-configured fails ......................................................................
tool: Fix help message when is-configured fails
When is-configured fails for some modules, the help message suggested an incorrect invocation:
vdsm-tool configure module-name
Instead of the correct:
vdsm-tool configure --module module-name
Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127877 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/31783 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/32059 Tested-by: mooli tayer mtayer@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved mooli tayer: Verified
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
Patch Set 4:
actually the bug url here is wrong. didn't catch it. please ignore, this just doc text fix
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Fix help message when is-configured fails ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/117/ : FAILURE
vdsm-patches@lists.fedorahosted.org