Gal Hammer has uploaded a new change for review.
Change subject: Added an option to create a balloon device on VM creation. ......................................................................
Added an option to create a balloon device on VM creation.
The "balloonEnabled" parameter allow to create a guest with a virtual memory balloon device attached.
Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 --- M vdsm/libvirtvm.py M vdsm_cli/vdsClient.py 2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/1573/1 -- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a balloon device on VM creation. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 727: if self.conf.get('balloonEnabled', None): You can get this parameter as string from xmlRpc. So, the right thing to do is: if utils.tobool(self.conf.get('balloonEnabled', False)):
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Eduardo has posted comments on this change.
Change subject: Added an option to create a balloon device on VM creation. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
A virtual memory balloon device is added to all Xen and KVM/QEMU guests. It will be automatically added when appropriate, so there is no need to explicitly add this element in the guest XML unless a specific PCI slot needs to be assigned or the device should be disabled.
Please do the right thing.
.................................................... Commit Message Line 7: Added an option to create a balloon device on VM creation. A virtual memory balloon device is added to all Xen and KVM/QEMU guests. Therefore this patch adds the disable cap.
.................................................... File vdsm/libvirtvm.py Line 724: def _appendBalloon(self): Since the balloon is a device should be a class as the other devices: disk and network. Should support addresses, which is in libvirt capabilities, and have a getXml method.
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vm.py Line 422: devices[BALLOON_DEVICES].append({'type': CONTROLLER_DEVICES, Why CONTROLLER_DEVICES ?
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Gal Hammer has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/vm.py Line 422: devices[BALLOON_DEVICES].append({'type': CONTROLLER_DEVICES, A copy&paste typo. Fixed.
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
.................................................... File vdsm/libvirtvm.py Line 1885: xml = xml.dom.minidom.parseString(self._lastXMLDesc) \ c'mon man. 'xml' is a valid python module, you can't use it as local variable. Please consider something like 'balloonxml'
Line 1887: .getElementsByTagName('memballon') memballon -> memballoon
.................................................... File vdsm/vm.py Line 423: 'device': 'memballon', 'model': 'none'}) memballon -> memballoon
Line 424: I think that right think it's to move this code to separate function like getConfBallon(). In such case you will call it only for old API (instead of []) and you shouldn't to check len()
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 5: (1 inline comment)
.................................................... File vdsm/vm.py Line 424: Hmmm, actually maybe I am wrong here, because also in new API we may not get the balloon device. So, you was right, leave it like this
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Gal Hammer has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 5: (4 inline comments)
.................................................... File vdsm/libvirtvm.py Line 1885: xml = xml.dom.minidom.parseString(self._lastXMLDesc) \ Done
Line 1887: .getElementsByTagName('memballon') Done
.................................................... File vdsm/vm.py Line 423: 'device': 'memballon', 'model': 'none'}) Done
Line 424: Done
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 6: Fails
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1258: for dev in devices[devType]: this explodes if no balloon device was passed.
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Gal Hammer has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1258: for dev in devices[devType]: Nice. But the question is how is it possible not to pass a balloon device? The code in in vm.py check if no balloon device exists and create one with a 'none' type.
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 8: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added an option to create a memory balloon device. ......................................................................
Patch Set 8:
blah, this patch has grown monstrously. I'll take it anyway...
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added an option to create a memory balloon device. ......................................................................
Added an option to create a memory balloon device.
A support for a virtual memory balloon device was added to the "devices" configuration.
Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 68 insertions(+), 13 deletions(-)
Approvals: Dan Kenigsberg: Igor Lvovsky: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org