Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP1/2] BZ#844656 Respawn the domain monitor when needed ......................................................................
[WIP1/2] BZ#844656 Respawn the domain monitor when needed
In the domain monitor there are few lines that are not covered by a try/except clause but that might be enough for the thread to die without leaving any valuable information in the logs. This patch adds logging for the possible exceptions and respawn the domain monitor if it exists unexpectedly.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc --- M vdsm/storage/domainMonitor.py 1 file changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/6787/1 -- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
.................................................... Commit Message Line 12: for the possible exceptions and respawn the domain monitor if it exists s/exists/exits/
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/domainMonitor.py Line 131: self.join() self.thread.join()
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 5: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Omri Hochman has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 6: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/54/
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/54/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
Patch Set 6: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#844656 Respawn the domain monitor when needed ......................................................................
BZ#844656 Respawn the domain monitor when needed
In the domain monitor there are few lines that are not covered by a try/except clause but that might be enough for the thread to die without leaving any valuable information in the logs. This patch adds logging for the possible exceptions and respawn the domain monitor if it exits unexpectedly.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc --- M vdsm/storage/domainMonitor.py 1 file changed, 113 insertions(+), 85 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Omri Hochman: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/6787 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I47e4fb6883d72578ee8083e46e4f660b656a5ffc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omri Hochman hoomri@gmail.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org