From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: migrate to new jsonrpc client ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/66940/1/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in:
Line 133: cli.Host.getCapabilities(), "Host.getCapabilities") Line 134: self.addObjectAsFile(cli.Host.getStats(), "Host.getStats") Line 135: self.addObjectAsFile( Line 136: cli.Host.getAllVmStats(), "Host.getAllVmStats") Line 137: self.addObjectAsFile(cli.Host.getVMList(), "Host.getVMList")
The old client was returning status code on errors, and we wrote this statu
why not doing it as we do the timeout, another optional parameter that says if call raise or return result always. depends if we have more usages like this Line 138: self.addObjectAsFile( Line 139: cli.Host.getDeviceList(), "Host.getDeviceList") Line 140: self.addObjectAsFile( Line 141: cli.Host.getAllTasksInfo(), "Host.getAllTasksInfo")
vdsm-patches@lists.fedorahosted.org