Federico Simoncelli has posted comments on this change.
Change subject: vm: spice support to clipboard copypaste disable ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/22646/3/vdsm/vm.py File vdsm/vm.py:
Line 1134: if self.conf.get('spiceSecureChannels'): Line 1135: for channel in self.conf['spiceSecureChannels'].split(','): Line 1136: graphics.appendChildWithArgs('channel', name=channel[1:], Line 1137: mode='secure') Line 1138: if not utils.tobool(self.conf.get('copyPasteEnable', True)): After __slots__ being merged I was expecting to see this appearing there too. Is it because the patch is not rebased or is it because we don't have __slots__ for these special devices? Line 1139: clipboard = XMLElement('clipboard', copypaste='no') Line 1140: graphics.appendChild(clipboard) Line 1141: Line 1142: vmc = XMLElement('channel', type='spicevmc')