Francesco Romani has posted comments on this change.
Change subject: v2v: add test for Xen block device ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
just one update and we are good to go. -1 for visibility
https://gerrit.ovirt.org/#/c/63022/3/tests/v2vTests.py File tests/v2vTests.py:
Line 533: vms = v2v.get_external_vms(self.xen_url, 'user', Line 534: ProtectedPassword('password'), Line 535: None)['vmList'] Line 536: Line 537: self.assertEqual(len(vms), len(VM_SPECS) - 1) please check that the missing VM is the one you set the disk type as block. Let's avoid the (unlikely?) case of some other VM missing Line 538: Line 539: @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V) Line 540: @MonkeyPatch(v2v, '_LOG_DIR', None) Line 541: def testSuccessfulImportOVA(self):