Petr Šebek has posted comments on this change.
Change subject: Avoid re-setting <boot> element when updating nic properties ......................................................................
Patch Set 1: Verified-1
When I tried to verify it there were this exception:
File "/usr/share/vdsm/vm.py", line 3093, in setLinkAndNetwork vnicXML.firstChild.removeChild(vnicXML.getElementsByTagName('boot')[0]) File "/usr/lib64/python2.6/xml/dom/minidom.py", line 164, in removeChild raise xml.dom.NotFoundErr() NotFoundErr
After that I tried to change that piece of code to:
try: vnicXML.firstChild.removeChild(vnicXML.getElementsByTagName('boot')[0] except xml.dom.NotFoundErr: pass
It fails with original exception:
libvirtError: this function is not supported by the connection driver: cannot modify network device boot index setting