Igor Lvovsky has posted comments on this change.
Change subject: Unify the volume creation code in volume.create ......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
minor comment
.................................................... File vdsm/storage/volume.py Line 385: (srcImgUUID, "srcImgUUID", True), (srcVolUUID, "srcVolUUID", True), hmmm, you just removed volUUID validation. I understand why you did it, but should we validate it somewhere?
-- To view, visit http://gerrit.ovirt.org/3627 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com