Alon Bar-Lev has posted comments on this change.
Change subject: setup: move the certificate generation ......................................................................
Patch Set 2:
Ayal,
Yes, the plugin or the application package should be node aware.
Anyway this is the responsibility of the packager for the node. It has nothing to do with 100 packages or so. One (or more) package should be responsible for the configuration of the node. In this case the package is vdsm as this is the meta package we installing. As I wrote in future there may be a vdsm plugin which will be maintained by us anyway, and we move <something> from <somewhere> to <different place>.
We need a solution for current implementation in which we do not have helper package.
There is no sense in discussing theoretical design pattern when we need a solution to a problem. First we provide a solution within current design, then improve design and fix the entire implementation.
Alon
-- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com