Wenyi Gao has posted comments on this change.
Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8 ......................................................................
Patch Set 2: (2 inline comments)
Thanks Saggi for reviewing the patches. Please see my inline comments.
.................................................... File vdsm_hooks/vhostmd/after_vm_destroy.py Line 31: if not [v for v in res['vmList'] No, this line code is not complete "if case", please note that the "]" matches the "[" near to "res" not "[" near to "v"
Line 32: if v.get('vmId') != os.environ.get('vmId') and "" is uneeded here because "and" is in the [ ..].
-- To view, visit http://gerrit.ovirt.org/4580 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I453051843d438574c3bd11a48a2f7a9543eefde2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com