Deepak C Shetty has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm ......................................................................
Patch Set 3: No score
@shaohef, Thanks for your review. I have not understood the tests/ framework entirely, so want to put down my understanding below...
1) vdsm-tests rpm has requires of vdsm rpm, so if vdsm-tests is installed, its safe to assume vdsm rpm is also installed.
2)tests/main.py and tests/gluster_cli_tests.py are part of vdsm-tests rpm.
3) Since my patch moves gluster/cli,exception,hostname}.py to vdsm rpm, i feel there is no need to check for Import error in tests/main.py and tests/gluster_cli_tests.py. It effectively means I just make them as ...
main.py: from gluster import exception as gluster_exception gluster_cli_tests.py: from gluster import cli as gcli
4) I will remove def setUp from main.py and gluster_cli_tests.py, since there is no need of the checks it does, as gluster cli and exception are available as part of vdsm rpm.
Let me know and/or correct my above understanding, post which I can send the next patchset.
thanx, deepak
-- To view, visit http://gerrit.ovirt.org/8033 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com