Alon Bar-Lev has posted comments on this change.
Change subject: setup: move the certificate generation ......................................................................
Patch Set 2:
I see the following code:
if ! vdsm_check_certificate; then echo -n $"Configuring the VDSM host certificate: " (vdsm_create_key && vdsm_create_ca && vdsm_create_cert) \ && success || failure; echo fi
Maybe I don't understand... but if vdsm_create_cert fails, we have leftovers from vdsm_create_key and vdsm_create_ca, where am I wrong?
I thought the whole point of these keys are to serve environment without engine, as in environments with engine we generate keys at bootstrap.
If that indeed the purpose, for these environment running on ovirt-node we need to persist the keys as no engine will do that for vdsm.
Thanks!
-- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com