Federico Simoncelli has posted comments on this change.
Change subject: [WIP] Unify the volume creation code in volume.create ......................................................................
Patch Set 2: (3 inline comments)
.................................................... File vdsm/storage/volume.py Line 388: raise se.InvalidParameterException("volUUID", volUUID) Done
Line 421: volParent.share(imgPath, hard=False) Done
Line 449: [sdUUID, volUUID, volPath]) Yes
-- To view, visit http://gerrit.ovirt.org/3627 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com