Shu Ming has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm.spec.in Line 692: %{_datadir}/%{vdsm_name}/neterrors.py* Line 693: %{_datadir}/%{vdsm_name}/respawn Line 694: %{_datadir}/%{vdsm_name}/set-conf-item Line 695: %{_datadir}/%{vdsm_name}/gluster/cli.py* Line 696: %{_datadir}/%{vdsm_name}/gluster/exception.py* Have you tested the installation of vdsm package without %{_datadir}/%{vdsm_name}/gluster directory initially? I am suspicious a "%dir ${_datadir}/%{vdsm_name}/gluster" directive is needed to create the directory? Line 697: %{python_sitelib}/sos/plugins/vdsm.py* Line 698: /lib/udev/rules.d/12-vdsm-lvm.rules Line 699: /etc/security/limits.d/99-vdsm.conf Line 700: %{_mandir}/man8/vdsmd.8*
-- To view, visit http://gerrit.ovirt.org/8033 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com