Dan Kenigsberg has posted comments on this change.
Change subject: A new method to read from VMs' channels. ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/vmChannels.py Line 111: read_callback, timeout_callback, param) I think it is ugly and unpythonic, but it does adhere to the http://en.wikipedia.org/wiki/Principle_of_least_action
-- To view, visit http://gerrit.ovirt.org/869 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com