ShaoHe Feng has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm ......................................................................
Patch Set 3: I would prefer that you didn't submit this
please also fix../tests/gluster_cli_tests.py and ../tests/main.py. these files in /test also import gluster.if gluster rpm is not installed, these test will pass when can not import import gluster.
now you have move gluster to vdsm rpm, the test should report error when can not import gluster.
-- To view, visit http://gerrit.ovirt.org/8033 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com