Nir Soffer has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot ......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/25988/3/tests/volumeTests.py File tests/volumeTests.py:
Line 97: self.assertEqual(mdSlot, self.EXPECTED_METADATA_SLOT) Line 98: Line 99: def testMetaSlotLock(self): Line 100: with self.blksd.getVolumeMetadataSlot(None, 1): Line 101: lktaken = self.blksd._lvTagMetaSlotLock.acquire(False)
This will break if we rename the private lock or move it to other class. We
See http://gerrit.ovirt.org/30938 for a way to test this without poking into blockVolume internals.