Yaniv Bronhaim has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
......................................................................
Patch Set 6: Code-Review+1
I assumed that you (vdsm) do want to kill its subprocesses cleanly. But as you say, this might grants that we won't have zombies as the zombierepear did (btw, it means that we can remove it now?) . I agree with this say, just tried to find the length of this timeout you refer to and I couldn't find exact values for how long systemd will wait before the sigkill..
Another btw, don't we want to set it in supervdsmd.service as well instead of zombierepear to be consist with the behavior ? I would love to hear more opinions about it ...
--
To view, visit
https://gerrit.ovirt.org/45038
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Dima Kuznetsov
dmitrykuzn@gmail.com
Gerrit-Reviewer: Douglas Schilling Landgraf
dougsland@redhat.com
Gerrit-Reviewer: Fabian Deutsch
fabiand@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali
oourfali@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: No