Dan Kenigsberg has posted comments on this change.
Change subject: A new method to read from VMs' channels. ......................................................................
Patch Set 10: Looks good to me, approved
(5 inline comments)
Gal, I'm taking this in due to my own time constraints. Please fix my comments in a later patch.
.................................................... File vdsm/vmChannels.py Line 65: self.log.exception("Exception on timeout callback.") exc_info=True
Line 93: try: with self._update_lock: bla
is so nicer!
Line 108: if obj['connect_cb'](obj['opaque']) == True: I find comparing to True redundant.
Line 115: self.log.exception("Exception on connect callback.") logging the exception here is highly recommended. exc_info=True
Line 148: try: with
-- To view, visit http://gerrit.ovirt.org/869 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com