Wenyi Gao has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool ......................................................................
Patch Set 4: (9 inline comments)
Dan, thanks for your suggestion. I will divide it into some small patches.
.................................................... File vdsm-tool/vdsmd.py Line 133: def _print_success_msg(msg): Dan, the function don't print the output of 'success'. It just behaves like other initial boot script and pints '[ OK ]' as following:
configure ....... [ OK ]
Line 366: return False Yes, good suggestion.
Line 427: return 6 Yes, a constant is better.
Line 475: ssl == 'true'): Yes, good.
Line 547: f.write('%s\n' % VDSM_SYSCTL_VER) Yes, it makes sense.
Line 562: Stop libvirt SysV service if we intend to configure upstart Yes.
Line 565: if(_upstart_libvirt()): Yes.
Line 596: @vdsm_tool_expose('vdsm-start') Yes, good point, I will make some smaller functions exposed.
Line 749: _reconfigure(False) Yes, looks very simple.
-- To view, visit http://gerrit.ovirt.org/4738 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I52db67207532ac7ded51cdd8c5dc388e85629104 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com