Zhou Zheng Sheng has uploaded a new change for review.
Change subject: extract a method for appending a child node with a text node to self.dom in libvirtvm.py ......................................................................
extract a method for appending a child node with a text node to self.dom in libvirtvm.py
In vdsm/libvirtvm.py, there are some duplicated code. It creates an xml element node, then creates a text node and appends it to the element, at last appends the element to self.dom. This can be done in a function.
Change-Id: Ie05d8f0f9869080b34d5cafb5c672d4034f09934 Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/6846/1 -- To view, visit http://gerrit.ovirt.org/6846 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie05d8f0f9869080b34d5cafb5c672d4034f09934 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com