Michal Skrivanek has posted comments on this change.
Change subject: net: Ignore missing graphics from VM conf on target host ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py File vdsm/virt/vm_migrate_hook.py:
Line 82: raise VmMigrationHookError('No devices entity in VM conf') Line 83: Line 84: try: Line 85: _set_graphics(devices, target_vm_conf) Line 86: except VmMigrationMissingDisplayConf:
I am not sure if that will be even correct.
it is definitely eventually going to be dropped, so yes, it should be documented when it's no longer relevant Line 87: # Due to a bug in Engine, there can be a scenario where the domxml Line 88: # includes a graphics section, however, the VM config on target does Line 89: # not. In such cases, ignore and do not touch this section. Line 90: pass