Yaniv Bronhaim has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/supervdsm.py Line 43: # path of supervdsmServer Line 44: for serverFile in ("supervdsmServer.py", "supervdsmServer.pyc"): Line 45: serverPath = os.path.join(base, serverFile) Line 46: if os.path.exists(serverPath): Line 47: return os.path.abspath(serverPath) I need it later when i execute supervdsmServer. You right that I shouldn't rely on the file's suffix.
I work now on changing the execution of supervdsm as in external service, and all this scope is about of being removed. Till then, this must be fixed, if you think this solution is inappropriate I'll add python -m and load the module without the suffix. is it sound better? Line 48: Line 49: raise RuntimeError("SuperVDSM Server not found") Line 50: Line 51: PIDFILE = os.path.join(constants.P_VDSM_RUN, "svdsm.pid")
-- To view, visit http://gerrit.ovirt.org/10854 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server